(bugfix)(torchx/runner) properly remove TORCHX_ prefix from env var before setting scheduler_params #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore setting scheduler_params
Summary:
kwargs to `create_scheduler()` scheduler factory method can be specified via the env var `TORCHX_{ARGUMENT_NAME}=arg_value`.
For example: `TORCHX_TIER=prod` would call the factory method as `create_scheduler(session_name, tier="prod")`.
Python's `str.strip("torchx_")` doesn't remove the prefix `torchx_` but rather strips any characters `t`, `o`, `r`, `c`, `h`, `x`, `_` from the front and back of the string.
Change to using `str.removeprefix("torchx_")` which does what we intended it to.
Reviewed By: ethanbwaite
Differential Revision: D79473894
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79473894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
kwargs to
create_scheduler()scheduler factory method can be specified via the env varTORCHX_{ARGUMENT_NAME}=arg_value.For example:
TORCHX_TIER=prodwould call the factory method ascreate_scheduler(session_name, tier="prod").Python's
str.strip("torchx_")doesn't remove the prefixtorchx_but rather strips any characterst,o,r,c,h,x,_from the front and back of the string.Change to using
str.removeprefix("torchx_")which does what we intended it to.Reviewed By: ethanbwaite
Differential Revision: D79473894